Tighten regex match for wildcard certs [Addendum to #1018] #1227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilevauge
approved these changes
Mar 3, 2017
Member
emilevauge
left a comment
emilevauge
left a comment
There was a problem hiding this comment.
LGTM
Thanks @dtomcej
/cc @containous/traefik
emilevauge
force-pushed
the
tighter-regex
branch
from
a4b78f5 to
9cd76f1
Compare
Member
|
@dtomcej I rebased it against master before merging. |
ldez
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wildcard certs are getting matched too far down:
bacon.text.example.com was matching *.example.com, when it shouldn't.
This regex update removes that match.