Skip to content

doc: small documentation review #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
emilevauge merged 1 commit into from
May 1, 2017
Merged

doc: small documentation review #1516

emilevauge merged 1 commit into from
May 1, 2017

Conversation

@ldez
Copy link
Contributor

@ldez ldez commented Apr 30, 2017

Description

  • fix syntax coloration.
  • same language, same code fence.
  • fix typo.
  • add some magic.

@ldez ldez added this to the 1.3 milestone Apr 30, 2017
@ldez ldez force-pushed the refactor/documentation-review branch from 1cb4d82 to 5c1cdd3 Compare April 30, 2017 18:24
@ldez ldez changed the title refactor: small documentation review doc: small documentation review Apr 30, 2017
timoreimann
timoreimann reviewed Apr 30, 2017
View reviewed changes
docs/basics.md Outdated
Copy link
Contributor

@timoreimann timoreimann Apr 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra leading space?

docs/user-guide/kubernetes.md Outdated
Copy link
Contributor

@timoreimann timoreimann Apr 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why, but still ☺️

Copy link
Contributor Author

@ldez ldez Apr 30, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://docs.traefik.io/user-guide/swarm/#access-to-your-apps-through-trfk 😉

Copy link
Contributor

@timoreimann timoreimann May 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

@ldez ldez force-pushed the refactor/documentation-review branch from 5c1cdd3 to 5526028 Compare April 30, 2017 18:56
timoreimann
timoreimann approved these changes Apr 30, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

emilevauge
emilevauge approved these changes May 1, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ldez
LGTM

@ldez ldez force-pushed the refactor/documentation-review branch from 5526028 to 4c4b05d Compare May 1, 2017 16:09
@emilevauge emilevauge merged commit bec45bc into traefik:master May 1, 2017
@ldez ldez deleted the refactor/documentation-review branch May 1, 2017 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilevauge emilevauge emilevauge approved these changes

+1 more reviewer

@timoreimann timoreimann timoreimann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/documentation

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@ldez @timoreimann @emilevauge