Skip to content

Get testify/require dependency. #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ldez merged 1 commit into from
May 23, 2017
Merged

Get testify/require dependency. #1658

ldez merged 1 commit into from
May 23, 2017

Conversation

@timoreimann
Copy link
Contributor

@timoreimann timoreimann commented May 23, 2017

This is required in order for #1638 to be mergeable.

@timoreimann timoreimann added this to the 1.3 milestone May 23, 2017
@timoreimann timoreimann requested review from emilevauge and ldez May 23, 2017 22:33
ldez
ldez approved these changes May 23, 2017
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 4293446 into traefik:v1.3 May 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilevauge emilevauge emilevauge approved these changes

+1 more reviewer

@ldez ldez ldez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kind/enhancement a new or improved feature.

Projects

None yet

Milestone

1.3

Development

Successfully merging this pull request may close these issues.

3 participants

@timoreimann @ldez @emilevauge