Fix #170 - getBackend for marathon plugin #171
Conversation
tayzlor
force-pushed
the
fix-170-marathon-getbackend
branch
from
43ea035 to
e921ceb
Compare
templates/marathon.tmpl
Outdated
There was a problem hiding this comment.
breaks because this is inside the range .Tasks so its passing a task instead of an application struct. so we need to pass back through the application here, but i'm not sure on how to do that
tayzlor
force-pushed
the
fix-170-marathon-getbackend
branch
from
e921ceb to
0e796f1
Compare
|
Hi @tayzlor, thank you for your contribution. What kind of issue do you have with your environment? |
tayzlor
force-pushed
the
fix-170-marathon-getbackend
branch
from
0e796f1 to
82ffd0e
Compare
|
Was my bad - spent a bit of time sorting out my Go setup and got the tests working. Latest push should fix the failing tests |
|
LGTM 🎉 |
tayzlor
force-pushed
the
fix-170-marathon-getbackend
branch
from
632b153 to
82ffd0e
Compare
…y traefik.backend via labels on the container
tayzlor
force-pushed
the
fix-170-marathon-getbackend
branch
from
82ffd0e to
2d79c50
Compare
|
rebased ⚡ |
|
LGTM 🐮 |
Fix #170 - getBackend for marathon plugin
| {{$apps := .Applications}} | ||
| [backends]{{range .Tasks}} | ||
| [backends.backend{{.AppID | replace "/" "-"}}.servers.server-{{.ID | replace "." "-"}}] | ||
| [backends.backend{{with index $apps 0 }}{{getBackend .}}{{end}}.servers.server-{{.ID | replace "." "-"}}] |
There was a problem hiding this comment.
I think there is an issue here with index $apps 0 :'(
You should have sent all apps, like in getProtocol and compare the ID in the fonction I think.
3 participants
PR for this enclosed.
No golang expert - I wasn't able to test this properly since I had some issues with my local env and following the instructions to run the test harness.