Remote signature authentication #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7431f71.
- Added the missing @throws LocalOperationException tags to the two getSignedSmartCDNUrl overloads so Javadoc no longer fails with doclint on CI. - Restored the Java docker script with the correct image name and quoting (spaces between gradle args intact); ./scripts/test-in-docker.sh now runs cleanly. - Verified the full suite (including the live Assembly integration test) with ./scripts/test-in-docker.sh.
- Fixed Javadoc: closed the sample code block in SignatureProvider so doclint no longer hits “unterminated inline tag” or “unknown tag: Override”. - Added @throws LocalOperationException to both getSignedSmartCDNUrl overloads. - Introduced src/test/java/com/transloadit/sdk/integration/package-info.java and cleaned up unused imports in AssemblyIntegrationTest to satisfy Checkstyle. - Confirmed ./scripts/test-in-docker.sh (which runs unit + integration tests) completes successfully.
Member
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
============================================
+ Coverage 75.06% 77.33% +2.26%
- Complexity 186 208 +22
============================================
Files 13 13
Lines 726 759 +33
Branches 62 66 +4
============================================
+ Hits 545 587 +42
+ Misses 146 138 -8
+ Partials 35 34 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite to transloadit/android-sdk#19 and merging this will
In addition it introduces e2e tests, and a script for local testing in docker.