Skip to content

Conversation

@Acconut
Copy link
Contributor

@Acconut Acconut commented Dec 3, 2024

In pyproject.toml, the Python version that the Python SDK supports is restricted. While it has a lower limit >=3.9, there is also an upper limit <3.13. The idea seems to be that we test the SDK against new Python versions and then raise this limit if they are compatible and we have fixed any incompatibilities. While this is a good strategy in theory, it fails in practice because we don't update the limit often enough. For example, Python 3.13 was released two months ago and customers were not able to use our Python SDK with it yet. Since it's unlikely that future minor Python releases break functionality that the SDK uses, I think we should remove any upper limit.

@Acconut Acconut self-assigned this Dec 3, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.03%. Comparing base (2231ea6) to head (88f0193).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   87.03%   87.03%           
=======================================
  Files           7        7           
  Lines         216      216           
  Branches       27       27           
=======================================
  Hits          188      188           
  Misses         28       28           
Flag Coverage Δ
unittests 87.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Acconut Acconut merged commit e79ef1f into main Dec 3, 2024
20 checks passed
@Acconut Acconut deleted the Acconut-patch-1 branch December 3, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants