Skip to content

Conversation

Copy link

Copilot AI commented Aug 24, 2025

Update jfr-connection module to follow style guide

Based on analysis of the jfr-connection module code against docs/style-guide.md, here are the minimal changes needed:

Analysis Summary

  • Code formatting: Already passes spotlessCheck ✅
  • Build and tests: All passing ✅
  • Add final keyword to public non-internal classes where appropriate
  • Add static imports for commonly used utility methods
  • Ensure test classes follow package-protected visibility convention

Implementation Plan

  • Make public non-internal classes final: JfrConnectionException, RecordingOptions, PredefinedConfiguration, JfcFileConfiguration, MapConfiguration, Recording
  • Add static imports for: Objects.requireNonNull, Collections., Arrays.
  • Remove public modifier from test classes to make them package-protected
  • Run tests and spotlessApply to ensure all changes work properly

Fixes #258.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update jfr-connection module to follow style guide

2 participants