Skip to content

Conversation

Copy link

Copilot AI commented Aug 24, 2025

  • Analyze current kafka-exporter code against style guide requirements
  • Update KafkaSpanExporter to follow style guide (add final, requireNonNull, @nullable)
  • Update KafkaSpanExporterBuilder to follow style guide (add final, static imports, requireNonNull)
  • Update SpanDataSerializer to follow style guide (add final, requireNonNull)
  • Update SpanDataDeserializer to follow style guide (add final)
  • Run tests and spotless to ensure changes are correct
  • Verify minimal changes and functionality preservation

Making minimal changes to update kafka-exporter module to follow docs/style-guide.md where it does not already.

Key changes planned:

  1. Add final keyword to public classes per style guide
  2. Replace validation using Objects.isNull() with requireNonNull()
  3. Add appropriate static imports
  4. Add @Nullable annotations where parameters/fields can be null
  5. Ensure fields are final where possible

Fixes #266.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update kafka-exporter module to follow style guide

2 participants