Update noop-api module to follow style guide #273
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes minimal changes to align the noop-api module with the style guide requirements defined in
docs/style-guide.md.Changes Made
1. Added
finalkeyword to public classesPer the style guide requirement that "Public non-internal classes should be declared
finalwhere possible":NoopOpenTelemetry→public final class NoopOpenTelemetryNoopContextStorageProvider→public final class NoopContextStorageProvider2. Optimized static imports in test
Following the style guide recommendations for static imports:
import static java.util.concurrent.TimeUnit.DAYS;import java.util.concurrent.TimeUnit;DAYSinstead ofTimeUnit.DAYSin the test methodVerification
The noop-api module now fully complies with the project's style guide requirements.
Fixes #272.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.