Skip to content

Conversation

Copy link

Copilot AI commented Aug 24, 2025

This PR makes minimal changes to align the noop-api module with the style guide requirements defined in docs/style-guide.md.

Changes Made

1. Added final keyword to public classes

Per the style guide requirement that "Public non-internal classes should be declared final where possible":

  • NoopOpenTelemetrypublic final class NoopOpenTelemetry
  • NoopContextStorageProviderpublic final class NoopContextStorageProvider

2. Optimized static imports in test

Following the style guide recommendations for static imports:

  • Added import static java.util.concurrent.TimeUnit.DAYS;
  • Removed unused import java.util.concurrent.TimeUnit;
  • Used DAYS instead of TimeUnit.DAYS in the test method

Verification

  • All existing tests continue to pass
  • Build and spotless formatting checks pass
  • Changes are minimal (only 4 lines modified across 3 files)
  • No breaking changes to functionality or public API

The noop-api module now fully complies with the project's style guide requirements.

Fixes #272.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…tyle guide

Co-authored-by: trask <218610+trask@users.noreply.github.com>
Copilot AI changed the title [WIP] Update noop-api module to follow style guide Update noop-api module to follow style guide Aug 24, 2025
Copilot AI requested a review from trask August 24, 2025 20:27
Copilot finished work on behalf of trask August 24, 2025 20:27
@trask trask closed this Aug 24, 2025
@trask trask deleted the copilot/fix-272 branch October 20, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update noop-api module to follow style guide

2 participants