This repository was archived by the owner on Oct 8, 2018. It is now read-only.
Fix #18 Add disabled prop #19
Merged
+18
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisdmathis
approved these changes
Feb 12, 2018
Owner
travisdmathis
left a comment
travisdmathis
left a comment
There was a problem hiding this comment.
@thedeany thanks for the submission, I'll get this merged and deployed.
travisdmathis
suggested changes
Feb 12, 2018
Owner
travisdmathis
left a comment
travisdmathis
left a comment
There was a problem hiding this comment.
Can you update the README as well please @thedeany then I will merge this in.
travisdmathis
approved these changes
Feb 17, 2018
Contributor
Author
|
I apologize for not getting to the requested changes before now! Thanks for doing it and for merging my PR. |
Owner
|
@thedeany no problem what so ever. Thank you for submitting the addition and improving the component. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
disabledprop to the element and added thepropTypeanddefaultPropfor it. I also updated the Jest snapshot so the tests run correctly. I did not add any new tests.