Skip to content

Conversation

@BekaValentine
Copy link
Contributor

@BekaValentine BekaValentine commented Jan 24, 2023

This PR adds queries to support GH code search.

Blackbird is the name of the GH code search tool that tags.scm was intended to support. For some reason the code search team was not using ts-internal tag queries and was instead using their own custom queries and we're now moving those queries upstream so that any service that wants to index name symbols in a way consistent with other services can rely on the tag queries.

Checklist:

  • All tests pass in CI.
  • The script/parse-examples passes without issues.
  • There are sufficient tests for the new fix/feature.
  • Grammar rules have not been renamed unless absolutely necessary.
  • The conflicts section hasn't grown too much.
  • The parser size hasn't grown too much (check the value of STATE_COUNT in src/parser.c).

@BekaValentine BekaValentine marked this pull request as ready for review January 24, 2023 17:54
@aryx
Copy link
Contributor

aryx commented Jan 24, 2023

Care to explain what blackbird queries are?

@BekaValentine
Copy link
Contributor Author

Care to explain what blackbird queries are?

Sure! Blackbird is the name of the GH code search tool that the tags.scm was intended to support. For some reason the code search team was not using ts-internal tag queries and was instead using their own custom queries and we're now moving those queries upstream so that any service that wants to index name symbols in a way consistent with other services can rely on the tag queries.

Copy link
Contributor

@aryx aryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add comment explaining the use of this export_statement
thing but whatever.

@aryx aryx merged commit 15e85e8 into tree-sitter:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants