Skip to content

Dvc formatting review #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2019
Merged

Dvc formatting review #1916

merged 2 commits into from
Apr 23, 2019

Conversation

@Suor
Copy link
Contributor

@Suor Suor commented Apr 23, 2019

This fixes after-review of #1885.

@Suor Suor mentioned this pull request Apr 23, 2019
Merged
@efiop efiop requested a review from a user April 23, 2019 10:07
efiop
efiop approved these changes Apr 23, 2019
View reviewed changes
Copy link
Contributor

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @MrOutis

ghost
ghost approved these changes Apr 23, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Suor , it looks good! However I still don't get what is the benefit of having a debug fixture instead of using directly the caplog one. I guess it is just to save some keystrokes 😛

@efiop efiop merged commit ee8d9a1 into treeverse:master Apr 23, 2019
@Suor
Copy link
Contributor Author

Suor commented Apr 24, 2019

debug is a autouse fixture, so it's applied to all tests automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@efiop efiop efiop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Suor @efiop