Skip to content

metrics: diff: fix float precision formatting #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efiop merged 1 commit into from
Apr 7, 2020
Merged

metrics: diff: fix float precision formatting #3609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dvc/command/metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,9 @@ def _show_diff(diff):

table = Texttable()

# disable automatic formatting
table.set_cols_dtype(["t", "t", "t", "t"])

# remove borders to make it easier for users to copy stuff
table.set_chars(("", "", "", ""))
table.set_deco(0)
Expand Down
9 changes: 9 additions & 0 deletions tests/unit/command/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,3 +119,12 @@ def test_metrics_show(dvc, mocker):
all_branches=True,
all_commits=True,
)


def test_metrics_diff_prec():
assert _show_diff(
{"other.json": {"a.b": {"old": 0.0042, "new": 0.0043, "diff": 0.0001}}}
) == (
" Path Metric Value Change\n"
"other.json a.b 0.0043 0.0001"
)