Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Nov 11, 2020

Tests started to fail recently with

c:\hostedtoolcache\windows\python\3.6.8\x64\lib\site-packages\moto\core\models.py:17: in <module>
    import responses
c:\hostedtoolcache\windows\python\3.6.8\x64\lib\site-packages\responses.py:29: in <module>
    from urllib3.connection import HTTPHeaderDict
E   ImportError: cannot import name 'HTTPHeaderDict'

caused by getsentry/responses#354

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@efiop
Copy link
Contributor Author

efiop commented Nov 11, 2020

Ok, doesn't really help in CI (works locally though). Seems like it might be something with dep resolution, need to take a look...

```
c:\hostedtoolcache\windows\python\3.6.8\x64\lib\site-packages\moto\core\models.py:17: in <module>
    import responses
c:\hostedtoolcache\windows\python\3.6.8\x64\lib\site-packages\responses.py:29: in <module>
    from urllib3.connection import HTTPHeaderDict
E   ImportError: cannot import name 'HTTPHeaderDict'
```
@efiop efiop merged commit de01b11 into master Nov 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the efiop-patch-2 branch November 11, 2020 15:30
@efiop efiop added the skip-changelog Skips changelog label Nov 11, 2020
I159 added a commit to I159/dvc that referenced this pull request Nov 12, 2020
…limit

* 'master' of github.com:iterative/dvc:
  dag: add --outs option (treeverse#4739)
  Add test server and tests for webdav (treeverse#4827)
  Simpler param updates with python-benedict (treeverse#4780)
  checkpoints: set DVC_ROOT environment variable (treeverse#4877)
  api: add support for simple wildcards (treeverse#4864)
  tests: mark azure test as flaky (treeverse#4881)
  setup.py: limit responses version for moto (treeverse#4879)
  remote: avoid chunking on webdav. Fixes treeverse#4796 (treeverse#4828)
  checkpoints: `exp run` and `exp res[ume]` refactor (treeverse#4855)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Skips changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant