live: Call webbrowser.open #6913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
reviewed
Nov 2, 2021
Use `funcy.once_per_args` decorator to prevent opening the html multiple times if user closes first time. Closes treeverse/dvclive#180
skshetry
reviewed
Nov 12, 2021
Comment on lines
+33
to
+38
| url = index_path.as_uri() | ||
|
|
||
| if "Microsoft" in uname().release: | ||
| url = Path(index_path) / "index.html" | ||
|
|
||
| webbrowser_open(url) |
Collaborator
There was a problem hiding this comment.
Could you please move this piece to ui? Maybe as ui.launch (similar to click.launch) or ui.open_browser? We can handle all relpath, uri and WSL stuff inside it. What do you think?
Contributor
Author
There was a problem hiding this comment.
Sounds good. Will do
This was referenced Nov 17, 2021
Merged
skshetry
reviewed
Nov 22, 2021
|
|
||
| def test_dvc_generates_html_during_run(tmp_dir, dvc, mocker, live_stage): | ||
| show_spy = mocker.spy(dvc.live, "show") | ||
| webbrowser_open = mocker.patch("dvc.repo.live.webbrowser_open") |
Collaborator
There was a problem hiding this comment.
@daavoo, it seems that the above change affected all of the tests and now opens the browser while running the tests.
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Closes treeverse/dvclive#180