stage add: don't fail if unable to create .gitignore #8644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.12% // Head: 94.12% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #8644 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 435 435
Lines 33459 33459
Branches 4711 4711
=======================================
Hits 31494 31494
Misses 1536 1536
Partials 429 429 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
shcheklein
approved these changes
Nov 30, 2022
dtrifiro
approved these changes
Dec 1, 2022
skshetry
reviewed
Dec 1, 2022
Comment on lines
+146
to
+150
| ui.warn( | ||
| f"Could not create .gitignore entry in {exc.filename}." | ||
| " DVC will attempt to create .gitignore entry again when" | ||
| " the stage is run." | ||
| ) |
Collaborator
There was a problem hiding this comment.
I am not sure if we need a warning here.
skshetry
approved these changes
Dec 1, 2022
daavoo
force-pushed
the
stage-add-ignore
branch
from
c0c8fed to
799b97f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to iterative/example-repos-dev#153.
Fixes #5802
Not sure where to add a test for this