Skip to content

log_sklearn_plot: custom names break make_report #370

@dberenbaum

Description

@dberenbaum

Examples:

>>> from dvclive import Live
>>> live = Live()
INFO:dvclive:Report file (if generated): /Users/dave/repo/dvclive/report.html
>>> y_true = [0, 0, 1, 1]
>>> y_pred = [1, 0, 1, 0]
>>> y_score = [0.1, 0.4, 0.35, 0.8]
>>> live.log_sklearn_plot("confusion_matrix", y_true, y_pred, name="cm")
>>> live.make_report()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/dave/Code/dvclive/src/dvclive/live.py", line 239, in make_report
    make_report(self)
  File "/Users/dave/Code/dvclive/src/dvclive/report.py", line 105, in make_report
    renderers.extend(get_plot_renderers(plots_path / SKLearnPlot.subfolder))
  File "/Users/dave/Code/dvclive/src/dvclive/report.py", line 68, in get_plot_renderers
    properties = SKLEARN_PLOTS[name].get_properties()
KeyError: 'cm'
>>> from dvclive import Live
>>> live = Live()
INFO:dvclive:Report file (if generated): /Users/dave/repo/dvclive/report.html
>>> y_true = [0, 0, 1, 1]
>>> y_pred = [1, 0, 1, 0]
>>> y_score = [0.1, 0.4, 0.35, 0.8]
>>> live.log_sklearn_plot("roc", y_true, y_score, name="roc_curve")
>>> live.make_report()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/Users/dave/Code/dvclive/src/dvclive/live.py", line 239, in make_report
    make_report(self)
  File "/Users/dave/Code/dvclive/src/dvclive/report.py", line 105, in make_report
    renderers.extend(get_plot_renderers(plots_path / SKLearnPlot.subfolder))
  File "/Users/dave/Code/dvclive/src/dvclive/report.py", line 67, in get_plot_renderers
    row["rev"] = "workspace"
TypeError: 'str' object does not support item assignment

Metadata

Metadata

Assignees

Labels

A: log_sklearn_plotArea: `live.log_sklearn_plot`bugDid we break something?p0-criticalHandle immediately

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions