Skip to content

Conversation

@pacifikus
Copy link
Contributor

Closes #132

PR to dvc docs: treeverse/dvc.org/pull/2699

@daavoo daavoo changed the title Dev Added LightGBM Aug 9, 2021
@daavoo daavoo self-requested a review August 9, 2021 07:10
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2021

Codecov Report

Merging #134 (71092cf) into master (bff563d) will increase coverage by 0.47%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   88.81%   89.28%   +0.47%     
==========================================
  Files          11       12       +1     
  Lines         295      308      +13     
==========================================
+ Hits          262      275      +13     
  Misses         33       33              
Impacted Files Coverage Δ
dvclive/lgbm.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff563d...71092cf. Read the comment docs.

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @pacifikus !

I just have a small comment regarding model saving.

Save model at the end of each iteration

Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
@pacifikus
Copy link
Contributor Author

Thanks for the contribution @pacifikus !

I just have a small comment regarding model saving.

Thank you for your comment! Changes have been made.

@daavoo daavoo self-requested a review August 9, 2021 08:54
@daavoo daavoo merged commit 36382c5 into treeverse:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

integrations: LightGBM

3 participants