Adding Docker image task to the deployment sub-project

[gregjan]

Includes a command.sh script that includes a migratedb and then server startup. There might be a better way to arrange that. For instance a docker-compose.yml file might specify a command that only starts the server.
I've added the commit ID as an image label. I'm mostly doing this as a way of tracking specific code with respect to performance test metrics. Should allow deeper investigation of outcomes through diffs.

[acoburn]

I don't know a lot about Docker images, but other than some very minor changes, this all looks good to me.

[acoburn]

Strangely, when I use this branch locally on JDK11, the grgit plugin seems to trigger a failure:

No .git directory found!

That's when running gradle clean (or any gradle command). It works fine on JDK8, even though the ./git directory is present in both environments. It also seemed to work fine on Travis-CI under JDK 11. Any ideas?

This also makes me think that a direct download (rather than clone) of the git repo wouldn't have the ./git directory, so maybe depending on the presence of a .git directory might cause problems later? Or maybe wrap the call in some sort of try ... catch block?

[gregjan]

I suppose that will work, as it's all groovy. I am still getting used to build scripts vs. build config..

…

On Mon, Sep 24, 2018 at 12:09 PM Aaron Coburn ***@***.***> wrote: Strangely, when I use this branch locally on JDK11, the grgit plugin seems to trigger a failure: No .git directory found! That's when running gradle clean (or any gradle command). It works fine on JDK8, even though the ./git directory is present in both environments. It also seemed to work fine on Travis-CI under JDK 11. Any ideas? This also makes me think that a direct download (rather than clone) of the git repo wouldn't have the ./git directory, so maybe depending on the presence of a .git directory might cause problems later? Or maybe wrap the call in some sort of try ... catch block? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AACFztKRjHHWYyhhi5OKQ5Hw0W-aHiYaks5ueQO_gaJpZM4W21RN> .

[gregjan]

Quite a mystery w/respect to JDK11 though. I haven't played with that java version as of yet. Does the rest of the code work fine in JDK 11? On Mon, Sep 24, 2018 at 12:33 PM Gregory Jansen <gregory.jansen@gmail.com> wrote:

…

I suppose that will work, as it's all groovy. I am still getting used to build scripts vs. build config.. On Mon, Sep 24, 2018 at 12:09 PM Aaron Coburn ***@***.***> wrote: > Strangely, when I use this branch locally on JDK11, the grgit plugin > seems to trigger a failure: > > No .git directory found! > > That's when running gradle clean (or any gradle command). It works fine > on JDK8, even though the ./git directory is present in both > environments. It also seemed to work fine on Travis-CI under JDK 11. Any > ideas? > > This also makes me think that a direct download (rather than clone) of > the git repo wouldn't have the ./git directory, so maybe depending on > the presence of a .git directory might cause problems later? Or maybe wrap > the call in some sort of try ... catch block? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#3 (comment)>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/AACFztKRjHHWYyhhi5OKQ5Hw0W-aHiYaks5ueQO_gaJpZM4W21RN> > . >

[acoburn]

Yes, the rest of the code works fine on JDK11

[acoburn]

@gregjan I got this to work on my local JDK 11 environment:

docker {
   ...
   def gitLabels = ['git.url':'https://github.com/trellis-ldp/trellis-ext-db']
   try {
       git = grgit.open()
       gitLabels.put('git.commit', git.head().id);
   } catch (all) {
   }
   labels(gitLabels)
   ...
}

(I moved the grgit code from the ext { ... } block to the docker { ... } block)