Type stuff #23
Merged
Type stuff #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This all looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits here: the first will be uncontroversial, I think-- it just adds in some type params to avoid compiler warnings. Maybe there's a reason not to, and if so, let's just skip it.
The other widens the return type of
ResourceService::get(in both forms) in order to deal with Java's craptacular generics and their lack of proper co/contravariance control. BecauseResourceService::getreturnsOptional<Resource>, I can't impl it withOptional<MyTypeThatImplsResource>because Java doesn't understand thatOptional<MyTypeThatImplsResource> "extends" Optional<Resource>. So now I can, at the cost of making some test mocking code look pretty gross... this lets impls ofResourceServiceusegetin their own code and get the actual type ofResourceat stake. This is useful becauseMyTypeThatImplsResourcecan have extra fresh members (in my case for Cassandra, a member that gives the Basic Containment container for that resource).Does that make sense?