Add detection that we are running inside a podman container#226
Closed
SvenVD wants to merge 1 commit intoCheckmk:masterfrom
Closed
Add detection that we are running inside a podman container#226SvenVD wants to merge 1 commit intoCheckmk:masterfrom
SvenVD wants to merge 1 commit intoCheckmk:masterfrom
Conversation
Not detecting that we are running in a podman container with --tmpfs makes the ./docker-entrypoint.sh and especially the 'omd create --no-tmpfs -u 1000 -g 1000 --admin-password "$CMK_PASSWORD" "$CMK_SITE_ID"' will fail because it uses the wrong path to check if the cmk site is already existing. Result is that it does not create a new site because it thinks it already exists ( because --tmpfs created the path)
Member
|
Thanks for your PR. It has passed review and will be merged soon (werk 11257). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not detecting that we are running in a podman container with --tmpfs makes the ./docker-entrypoint.sh and especially the 'omd create --no-tmpfs -u 1000 -g 1000 --admin-password "$CMK_PASSWORD" "$CMK_SITE_ID"' will fail because it uses the wrong path to check if the cmk site is already existing. Result is that it does not create a new site because it thinks it already exists ( because --tmpfs created the path)