Skip to content

Commit 1a7ee24

Browse files
authored
fix(ui): refresh deployments logs stream on status change (#2688)
The logs stream is created after the deployment moves from `PENDING` status to `INSTALLING`.
1 parent bb99af5 commit 1a7ee24

File tree

1 file changed

+2
-1
lines changed
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.deployments.$deploymentParam

1 file changed

+2
-1
lines changed

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.deployments.$deploymentParam/route.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ export default function Page() {
8484
const [logs, setLogs] = useState<LogEntry[]>([]);
8585
const [isStreaming, setIsStreaming] = useState(true);
8686
const [streamError, setStreamError] = useState<string | null>(null);
87+
const isPending = deployment.status === "PENDING";
8788

8889
useEffect(() => {
8990
if (logsDisabled) return;
@@ -157,7 +158,7 @@ export default function Page() {
157158
return () => {
158159
abortController.abort();
159160
};
160-
}, [s2Logs?.basin, s2Logs?.stream, s2Logs?.accessToken]);
161+
}, [s2Logs?.basin, s2Logs?.stream, s2Logs?.accessToken, isPending]);
161162

162163
return (
163164
<div className="grid h-full max-h-full grid-rows-[2.5rem_1fr] overflow-hidden bg-background-bright">

0 commit comments

Comments
 (0)