Skip to content

Conversation

@Senorsen
Copy link
Member

Replace hardcoded imagePullSecrets "registry-credentials" to values 😄

@cla-bot
Copy link

cla-bot bot commented Nov 30, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@michael-datareply
Copy link

This would be really great, can we somehow get this merged? :)

@cla-bot
Copy link

cla-bot bot commented Mar 15, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@dnskr
Copy link

dnskr commented Mar 16, 2022

@Senorsen Could you please sign CLA to be able to merge your PR?

@cla-bot
Copy link

cla-bot bot commented Mar 24, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@Senorsen
Copy link
Member Author

@dnskr @cla-bot CLA already signed.

@hashhar
Copy link
Member

hashhar commented Mar 24, 2022

@martint can you help with CLA here?

@Senorsen
Copy link
Member Author

@hashhar @dnskr CLA issue seems to be fixed after a re-push

@Senorsen Senorsen force-pushed the main branch 2 times, most recently from f54faa5 to 0246206 Compare March 30, 2022 02:42
The default value is still the old value so that chart upgrades don't
break users.
@hashhar hashhar merged commit 430126e into trinodb:main Mar 30, 2022
@hashhar hashhar changed the title feat: customizable imagePullSecrets Make imagePullSecrets secret name customizable Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants