Skip to content

Conversation

@ricosega
Copy link
Member

Just wanted to add an ingress resource and a catalog config iterator where you can add multiple configs.

@cla-bot
Copy link

cla-bot bot commented Apr 29, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@cla-bot
Copy link

cla-bot bot commented Apr 29, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@cla-bot
Copy link

cla-bot bot commented Apr 30, 2021

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@bitsondatadev
Copy link
Member

@ricosega, it looks like the ingress portion is superseded by #39 and the catalogs iterator is implemented by #1. I'm going to recommend to @hashhar that we close this PR unless you have any reason you think it should stay open.

@ricosega
Copy link
Member Author

@bitsondatadev well this was opened more than a year and a half ago so yes it can be closed.

@ricosega ricosega closed this Nov 19, 2022
@ricosega ricosega deleted the add-ingress-and-catalogs-config-iterator branch November 19, 2022 09:13
@bitsondatadev
Copy link
Member

@ricosega, I apologize for the delay on getting these reviewed. We've just set up a developer experience team to address and avoid these issues from happening in the future.

nineinchnick added a commit to nineinchnick/charts that referenced this pull request May 30, 2024
nineinchnick added a commit to nineinchnick/charts that referenced this pull request May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants