Skip to content

Add horizontal pod autoscaler #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Add horizontal pod autoscaler #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions charts/trino/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@ The following table lists the configurable parameters of the Trino chart and the
| `server.jvm.maxHeapSize` | | `"8G"` |
| `server.jvm.gcMethod.type` | | `"UseG1GC"` |
| `server.jvm.gcMethod.g1.heapRegionSize` | | `"32M"` |
| `server.autoscaling.enabled` | | `false` |
| `server.autoscaling.maxReplicas` | | `5` |
| `server.autoscaling.targetCPUUtilizationPercentage` | | `50` |
| `additionalNodeProperties` | | `{}` |
| `additionalJVMConfig` | | `{}` |
| `additionalConfigProperties` | | `{}` |
Expand Down
14 changes: 14 additions & 0 deletions charts/trino/templates/autoscaler.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
{{- if .Values.server.autoscaling.enabled -}}
apiVersion: autoscaling/v1
Copy link
Contributor Author

@Epicsteve2 Epicsteve2 Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: autoscaling/v2 is out, but it went General Availability for Kubernetes 1.23. I feel like that version is too new to include in this helm chart.

For reference, AWS doesn't even support Kubernetes 1.22 yet

kind: HorizontalPodAutoscaler
metadata:
name: {{ template "trino.worker" . }}
spec:
maxReplicas: {{ .Values.server.autoscaling.maxReplicas }}
minReplicas: {{ .Values.server.workers }}
scaleTargetRef:
apiVersion: apps/v1
kind: Deployment
name: {{ template "trino.worker" . }}
targetCPUUtilizationPercentage: {{ .Values.server.autoscaling.targetCPUUtilizationPercentage }}
{{- end }}
4 changes: 4 additions & 0 deletions charts/trino/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ server:
type: "UseG1GC"
g1:
heapRegionSize: "32M"
autoscaling:
enabled: false
maxReplicas: 5
targetCPUUtilizationPercentage: 50

additionalNodeProperties: {}

Expand Down