Skip to content

Provide different JVM configs for co-ordinator and workers #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2022
Merged

Provide different JVM configs for co-ordinator and workers #26

merged 1 commit into from
Mar 18, 2022

Conversation

@dragonslayer27
Copy link
Contributor

@dragonslayer27 dragonslayer27 commented Feb 18, 2022 •
edited
Loading

Original PR was here
This PR allows for separating jvm configs for coordinators/workers.

@cla-bot cla-bot bot added the cla-signed label Feb 18, 2022
@dragonslayer27 dragonslayer27 mentioned this pull request Feb 18, 2022
Closed
@dragonslayer27 dragonslayer27 force-pushed the habc12-separate-coordinator-worker-values branch from e3fbd14 to a06257e Compare February 18, 2022 19:44
@dragonslayer27
Copy link
Contributor Author

dragonslayer27 commented Feb 18, 2022

Frigate is ignoring the custom value files (values-worker.yaml & values-coordinator.yaml). Do you know if it's supported? They only mention Chart.yaml & values.yaml.

@dragonslayer27 dragonslayer27 force-pushed the habc12-separate-coordinator-worker-values branch from bafad3c to 1b891f4 Compare February 18, 2022 20:38
@habc12 habc12 force-pushed the habc12-separate-coordinator-worker-values branch 2 times, most recently from 01b54b2 to 30b6106 Compare March 7, 2022 19:07
@dragonslayer27
Provide different JVM configs for co-ordinator and workers
a53052f 
Provide different JVM configs for co-ordinator and workers
@dragonslayer27 dragonslayer27 force-pushed the habc12-separate-coordinator-worker-values branch from c0e1523 to a53052f Compare March 7, 2022 19:41
@hashhar
Copy link
Member

hashhar commented Mar 16, 2022

Frigate is ignoring the custom value files (values-worker.yaml & values-coordinator.yaml). Do you know if it's supported? They only mention Chart.yaml & values.yaml.

Neither Frigate nor helm-docs support that unfortunately. It's ok for now, at some point we might need to go back to handcrafted chart docs.

hashhar
hashhar reviewed Mar 16, 2022
View reviewed changes
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this makes it possible to have separate configs it seems to remove support for being able to use same configs?

cc: @joshthoward @przemekak

@przemekak
Copy link
Member

przemekak commented Mar 17, 2022

While this makes it possible to have separate configs it seems to remove support for being able to use same configs?

cc: @joshthoward @przemekak

True, still I think having possibility to set those configs separately is worth it.

@hashhar hashhar merged commit 571324e into trinodb:main Mar 18, 2022
@hashhar hashhar mentioned this pull request Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hashhar hashhar hashhar left review comments

Assignees

No one assigned

Labels

cla-signed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dragonslayer27 @hashhar @przemekak