Skip to content

Conversation

@linzebing
Copy link
Member

@linzebing linzebing commented Mar 2, 2022

Similar to trinodb/trino#11154, want to exchange-manager.properties as part of the dev setup for Helm charts.

Locally tested and deployed on EKS:

helm install --set additionalConfigProperties=\{"retry-policy=TASK","query.initial-hash-partitions=5","fault-tolerant-execution-target-task-input-size=10MB","fault-tolerant-execution-target-task-split-count=4","enable-dynamic-filtering=false","distributed-sort=false"\} \
  --set additionalExchangeManagerProperties=\{"exchange.s3.region=us-east-1","exchange.s3.aws-access-key=accessKey","exchange.s3.aws-secret-key=secretKey"\} \
  --set server.exchangeManager.baseDir="s3n://your-bucket-name"
  demo ./trino-0.4.0.tgz

and verified cluster is running in batch mode with S3 used for spooling.

@cla-bot cla-bot bot added the cla-signed label Mar 2, 2022
@linzebing
Copy link
Member Author

cc @hashhar, @joshthoward

@joshthoward
Copy link
Member

This looks good to me.

I would want to be able to pass through arbitrary configs in the future without having explicitly add configs to the chart, but that is separate from this feature enhancement.

@linzebing
Copy link
Member Author

Yes we are able to, e.g., use of additionalConfigProperties and additionalExchangeManagerProperties. In this PR it's because we need to add a separate config file, thus the change.

@hashhar hashhar changed the title Add exchange manager properties to charts Add support for configuring exchange manager properties Mar 3, 2022
@hashhar hashhar merged commit 183e60a into trinodb:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants