Skip to content

Conversation

@aksakalli
Copy link
Member

@aksakalli aksakalli commented Apr 1, 2022

I am getting an error for the newest version 0.6.0 with following instructions from the README.md:

helm repo add trino https://trinodb.github.io/charts/
helm install my-trino trino/trino --version 0.6.0 --dry-run --debug

gives:

Error: INSTALLATION FAILED: template: trino/templates/deployment-worker.yaml:64:30: executing "trino/templates/deployment-worker.yaml" at <.Values.worker.resources>: nil pointer evaluating interface {}.resources

values.yaml is the only default values file for helm charts and without specifying things like .Values.worker.resources, the chart fails.

$ helm version for reproducibility:

version.BuildInfo{Version:"v3.8.1", GitCommit:"5cb9af4b1b271d11d7a97a71df3ac337dd94ad37", GitTreeState:"clean", GoVersion:"go1.17.8"}

@cla-bot
Copy link

cla-bot bot commented Apr 1, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

@aksakalli
Copy link
Member Author

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

I signed it 3 days ago and I am still getting this message. 😞

@hashhar
Copy link
Member

hashhar commented Apr 1, 2022

The CLA gets processed in batches. Thanks for sending the PR. Can you please make sure README.md for the chart is in sync? You can look at the docs failure log and it includes a diff of what's expected vs what's present.

@hashhar
Copy link
Member

hashhar commented Apr 1, 2022

BTW see also #39

@hashhar hashhar force-pushed the fix-coordinator-worker-values branch from 9d3e3a4 to 822cec1 Compare April 1, 2022 04:56
@cla-bot
Copy link

cla-bot bot commented Apr 1, 2022

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@trino.io. For more information, see https://github.com/trinodb/cla.

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the chart version so that when I merge a new version gets released.

@hashhar hashhar mentioned this pull request Apr 1, 2022
@hashhar hashhar merged commit b50de31 into trinodb:main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants