Skip to content

Conversation

@wendigo
Copy link
Contributor

@wendigo wendigo commented Dec 3, 2024

We want to make sure that the collection won't be modified so wrapping it with unmodifiableCollection should be enough.

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

## Section
* Fix some things. ({issue}`issuenumber`)

We want to make sure that the collection won't be modified
so wrapping it with unmodifiableCollection should be enough.
@cla-bot cla-bot bot added the cla-signed label Dec 3, 2024
@wendigo wendigo requested a review from losipiuk December 3, 2024 15:46
Copy link
Member

@losipiuk losipiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally I feel it is not necessarily super useful. But not much harm neither.

@wendigo wendigo merged commit ddff01f into trinodb:master Dec 3, 2024
93 checks passed
@github-actions github-actions bot added this to the 467 milestone Dec 3, 2024
@wendigo wendigo deleted the serafin/query-tracker-copy branch December 3, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants