-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Clean up naming of ranger plugin properties #24392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Need to update docs as well as some config files used in the tests. |
These were missed when renaming the plugin module
c7c50bf to
a748dc8
Compare
|
Also to clarify for anybody else looking or reviewing .. we do not use the "apache" prefix for any other connector or module or user facing properties and we therefore want to rename this and stay consistent. It also makes it shorter. Given that the plugin just shipped in 466 the impact on users as a breaking change will be minimal and it is better to do the rename now than later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Heads up @lozbrown @mneethiraj @kokosing and @ksobolew
|
Could you confirm CI failure on master? https://github.com/trinodb/trino/actions/runs/12191471556/job/34010672844 |
|
Not sure how the PR build passed .. but anyway . this should fix it. #24394 |
Cheers for the heads up, have been working on getting this stuff working |
|
@martint, @mosabua, @lozbrown - the plugin was initially named as I don't have preference for one name over other. |
|
These changes are not mentioned in the release notes, are property renames not considered breaking changes? |
|
I think a note saying which properties were changed and AB's what the replacements were would be helpful We can't presume we know everyone who was trying out 466 |
|
yeah this should always be mentioned, it broke for us..we were on 466 and upgraded to 468 and this wasn't mentioned in the release notes. |
These were missed when renaming the plugin module
(x) Release notes are required, with the following suggested text: