Verify JUnit no tests shadowing #27114
Open
+72
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
wendigo
reviewed
Oct 27, 2025
...-testing-services/src/main/java/io/trino/testing/services/junit/ReportOverriddenMethods.java
Show resolved
Hide resolved
wendigo
reviewed
Oct 27, 2025
| !Modifier.isProtected(methodSource.getJavaMethod().getModifiers())) { | ||
| List<Class<?>> declaringClasses = Stream.<Class<?>>iterate(methodSource.getJavaClass(), clazz -> clazz.getSuperclass() != null, Class::getSuperclass) | ||
| .filter(clazz -> | ||
| Arrays.stream(clazz.getDeclaredMethods()) |
There was a problem hiding this comment.
can you extract these .filter body to a separate method for improved readability?
wendigo
approved these changes
Oct 27, 2025
|
squashing |
findepi
force-pushed
the
findepi/junit-dups
branch
from
6e1443b to
36dfa17
Compare
wendigo
force-pushed
the
findepi/junit-dups
branch
from
36dfa17 to
538c02a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for JUnit issue
tests that could be silently skipped by JUnit, are detected and test run is aborted.
Summary by Sourcery
Add a custom TestExecutionListener that scans the test plan for non-public test methods overriding superclass methods and fails early to avoid silent test skipping, and register it with JUnit’s service loader.
New Features:
Enhancements: