Fix Autocomplete To Use CPU When No GPU Found #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanmayv25
reviewed
May 6, 2022
CoderHam
suggested changes
May 6, 2022
rmccorm4
requested changes
May 6, 2022
rmccorm4
reviewed
May 6, 2022
tanmayv25
approved these changes
May 6, 2022
Contributor
|
@pranavsharma FYI, this is follow-up fix for #112. Before this fix the auto-complete will set all EPs as the model may contain EP-specific ops, but there is an edge case where model will fail to load if CUDA EP is set while there is no GPU on the system. With this change, the auto-complete will check GPU availability and set EPs conditionally |
rmccorm4
approved these changes
May 6, 2022
CoderHam
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes onnxruntime's autocomplete to check the instance(s) kind of the of the model before loading. If no GPU instance groups are found then autocomplete will set the kind to CPU before loading the model.