forked from CacheControl/json-rules-engine
-
Notifications
You must be signed in to change notification settings - Fork 0
[DO NOT MERGE] Sync upstream 20250522 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dmay-trm
wants to merge
98
commits into
master
Choose a base branch
from
sync-upstream-20250522
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor style edits
Update almanac.md
Add "not" boolean operator
Allow Conditions to include names that are emitted as part of events and can be serialized to / from JSON Names are useful to provide human readable tags on the different conditions, especially complex ones made up of nested boolean conditions.
Upgrades to HashIt and JSON Path Plus. These libraries are major versions out-of date.
Upgrades to Dependencies
Allow Named Conditions
Add Linting to the CI and move deployment out of the on pull request bit so it doesn't trigger on pull requests.
Add Linting to CI, split deployment
Bump Package Version to 6.2.0
fix the link to the boolean expressions that broke after not was introduced.
This will allow you to npm install examples and actually run them.
Add Support for Conditions which are added to the engine and then referenced in various rules. Condition references can be used as top-level conditions in a rule and can be used recursively.
Add documentation covering the use and advantages of condition sharing. Specifically on the ability to re-use the same condition across multiple rules.
Condition Sharing
commit 1356b48 Author: Emile Fokkema <emile.fokkema@navara.nl> Date: Sun Nov 10 20:08:27 2024 +0100 result and factResult are not always there commit 725fb66 Author: Emile Fokkema <emile.fokkema@navara.nl> Date: Sat Nov 9 20:07:13 2024 +0100 condition reference can be part of the result commit cb5f3c7 Author: Emile Fokkema <146825801+emilefokkemanavara@users.noreply.github.com> Date: Fri Nov 8 16:27:34 2024 +0000 there are no condition references in the result commit c688692 Author: Emile Fokkema <146825801+emilefokkemanavara@users.noreply.github.com> Date: Fri Nov 8 16:27:09 2024 +0000 begin to add condition result types commit 7a90a81 Author: Emile Fokkema <146825801+emilefokkemanavara@users.noreply.github.com> Date: Fri Nov 8 16:26:42 2024 +0000 add toJSON method to RuleResult
…ule-result-json fix: improve typing of RuleResult
Upgrade the Version Number to version 7.1.0
Upgrade Version Number to deploy 7.1.0
Add RightSideComparisonResult as factResult
New version 7.2.0 This will include changes to allow the resolved value of values to be present on the condition results.
Bump Version to 7.2.0
Upgrade JSON-Path-Plus to V10.2.0.
…type-rule-event call Rule.ruleEvent by its correct name
Increment Minor Version Number to release type fixes around ruleEvent property on the rule class.
Change removeOperator to removeOperatorDecorator
Typo - change documentation to removeOperatorDecorator
Upgrade JSON-Path-Plus to V10.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in all commits from the upstream while keeping our patch in place. We will need to do some extensive testing to make sure this doesnt break anything before we merge it in.