Add user-agent parameter to config #4
Conversation
| String name = task.getUserAgent().get().get("product_name"); | ||
| String version = task.getUserAgent().get().get("product_version"); | ||
|
|
||
| UserAgent.withProduct(name, version); |
There was a problem hiding this comment.
| return new DatabricksAPIClient(createDatabricksConfig(task)); | ||
| } | ||
|
|
||
| private static void SetUserAgent(DatabricksOutputPlugin.DatabricksPluginTask task) { |
There was a problem hiding this comment.
普通にメソッドなので先頭は小文字でいい気がします！僕の知らないお作法だったらごめんなさい！
| private static void SetUserAgent(DatabricksOutputPlugin.DatabricksPluginTask task) { | |
| private static void setUserAgent(DatabricksOutputPlugin.DatabricksPluginTask task) { |
|
|
||
| @Config("user_agent") | ||
| @ConfigDefault("{}") | ||
| public Optional<UserAgentEntry> getUserAgent(); |
There was a problem hiding this comment.
| public Optional<UserAgentEntry> getUserAgent(); | |
| public UserAgentEntry getUserAgentEntry(); |
- [MAY] If there is a default value, then
Optionalis not needed. - [SHOULD] If there is no special reason, it should be the same as the option name.
There was a problem hiding this comment.
fixed in this commit.
| props.put("ConnSchema", t.getSchemaName()); | ||
| props.putAll(t.getOptions()); | ||
| // overwrite UserAgentEntry property if the same property is set in options | ||
| if (t.getUserAgentEntry() != null) { |
There was a problem hiding this comment.
t.getUserAgentEntry always seems to be not null.
You might want to delete this line.
There was a problem hiding this comment.
The current code did not guarantee the behavior of 2 below, so changed condition.
- 1: options is not set & user-agent is not set => unknown/0.0.0
- 2: options is set & user-agent is not set => value of options
- 3: options is not set & user-agent is set => value of user-agent
- 4: options is set, user-agent is set => value of user-agent
There was a problem hiding this comment.
We have decided to always overwrite the UserAgentEntry value in options by user-agent, so please ignore the above comment. I removed condition as you commented.
| String product_name = t.getUserAgentEntry().getProductName(); | ||
| String product_version = t.getUserAgentEntry().getProductVersion(); | ||
|
|
||
| props.put("UserAgentEntry", product_name + "/" + product_version); |
There was a problem hiding this comment.
Java's variable names are usually camel case.
product_name -> productName
product_version -> productVersion
4 participants
overview
add optional user-agent parameter to JDBC and SDK connection