fix: properly check for duplicated route names and paths

Author: troch

modules/RouteNode.js

@@ -69,18 +69,20 @@ export default class RouteNode {
             originalRoute = route;
             route = new RouteNode(route.name, route.path, route.children);
         }
-        // Check duplicated routes
-        if (this.children.map(child => child.name).indexOf(route.name) !== -1) {
-            throw new Error(`Alias "${route.name}" is already defined in route node`);
-        }
-        // Check duplicated paths
-        if (this.children.map(child => child.path).indexOf(route.path) !== -1) {
-            throw new Error(`Path "${route.path}" is already defined in route node`);
-        }
 
         let names = route.name.split('.');
 
         if (names.length === 1) {
+            // Check duplicated routes
+            if (this.children.map(child => child.name).indexOf(route.name) !== -1) {
+                throw new Error(`Alias "${route.name}" is already defined in route node`);
+            }
+
+            // Check duplicated paths
+            if (this.children.map(child => child.path).indexOf(route.path) !== -1) {
+                throw new Error(`Path "${route.path}" is already defined in route node`);
+            }
+
             this.children.push(route);
             // Push greedy spats to the bottom of the pile
             this.children.sort((left, right) => {

test/main.js

@@ -95,6 +95,14 @@ describe('RouteNode', function () {
         (function () {
             root.add({name: 'profile', path: '/home'})
         }).should.throw('Path "/home" is already defined in route node');
+
+        (function () {
+            root.add({name: 'home.profile', path: '/home'})
+        }).should.not.throw();
+
+        (function () {
+            root.add({name: 'home.profile', path: '/profile'})
+        }).should.throw();
     });
 
     it('should throw an error when trying to add a route which parent doesn\'t exist', function () {