fix: don't try to build a path out of a null list of segments

troch · troch · commit d1817c3c30bc · 2015-09-04T20:07:09.000+01:00
diff --git a/modules/RouteNode.js b/modules/RouteNode.js
@@ -184,6 +184,8 @@ export default class RouteNode {
     }
 
     buildPathFromSegments(segments, params = {}) {
+        if (!segments) return null
+
         let searchParams = segments
             .filter(s => s.parser.hasQueryParams)
             .map(s => s.parser.queryParams);
@@ -194,7 +196,7 @@ export default class RouteNode {
             .map(p => p + '=' + params[p])
             .join('&')
 
-        return segments ? segments.map(segment => segment.parser.build(params, {ignoreSearch: true})).join('') + (searchPart ? '?' + searchPart : '') : null
+        return segments.map(segment => segment.parser.build(params, {ignoreSearch: true})).join('') + (searchPart ? '?' + searchPart : '')
     }
 
     buildPath(routeName, params = {}) {

Original file line number	Diff line number	Diff line change
`@@ -184,6 +184,8 @@ export default class RouteNode {`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`buildPathFromSegments(segments, params = {}) {`
	`187`	`+ if (!segments) return null`
	`188`	`+`
`187`	`189`	`let searchParams = segments`
`188`	`190`	`.filter(s => s.parser.hasQueryParams)`
`189`	`191`	`.map(s => s.parser.queryParams);`
`@@ -194,7 +196,7 @@ export default class RouteNode {`
`194`	`196`	`.map(p => p + '=' + params[p])`
`195`	`197`	`.join('&')`
`196`	`198`
`197`		`- return segments ? segments.map(segment => segment.parser.build(params, {ignoreSearch: true})).join('') + (searchPart ? '?' + searchPart : '') : null`
	`199`	`+ return segments.map(segment => segment.parser.build(params, {ignoreSearch: true})).join('') + (searchPart ? '?' + searchPart : '')`
`198`	`200`	`}`
`199`	`201`
`200`	`202`	`buildPath(routeName, params = {}) {`