Strip content of regexes from path before sorting#14
Merged
troch merged 1 commit intotroch:masterfrom Oct 15, 2017
Merged
Conversation
dgieselaar
force-pushed
the
strip-regex-before-sort
branch
from
b243257 to
8683210
Compare
dgieselaar
force-pushed
the
strip-regex-before-sort
branch
from
8683210 to
11de007
Compare
Owner
|
Great find, going to merge and release. I'll probably re-visit the sorting solution at some point so that the number of segments comes from path-parser. But will do for now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a regex contains a question mark (for instance, for an optional parameter, a negative lookahead, or a non-capturing group), the children of the route are not correctly sorted anymore, because they're cut off at the first question mark. This change removes the content of the regex before sorting.
Additionally, I've changed the test command to ensure it runs on Windows as well.