Skip to content

Conversation

@IngmarStein
Copy link
Member

Replace hardcoded URL strings (e.g., "/", "/auth/edit") with request.url_for() calls using named routes throughout auth.py and manager.py routers. This improves maintainability by centralizing route definitions and eliminates potential bugs from manually updating URLs across multiple files.

Replace hardcoded URL strings (e.g., "/", "/auth/edit") with
request.url_for() calls using named routes throughout auth.py and
manager.py routers. This improves maintainability by centralizing
route definitions and eliminates potential bugs from manually
updating URLs across multiple files.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @IngmarStein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the application's URL handling mechanism. It transitions from using static, hardcoded URL paths to a more dynamic and maintainable system that leverages named route references via request.url_for(). This change standardizes how URLs are generated throughout the auth and manager modules, making the codebase more resilient to future route modifications and reducing the likelihood of broken links.

Highlights

  • Centralized URL Management: Replaced hardcoded URL strings with request.url_for() calls using named routes across auth.py and manager.py routers.
  • Improved Maintainability: This refactoring centralizes route definitions, making the application more robust and easier to maintain by eliminating the need to manually update URLs in multiple locations.
  • Test Adjustments: Updated test assertions in test_api.py, test_register+login.py, and test_webp_upload.py to reflect the full http://testserver/ URLs generated by the test client, aligning with the new URL generation approach.
  • Dependency Cleanup: Removed an unused settings dependency from the post_register_owner function in auth.py.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great refactoring that replaces hardcoded URL paths with named route references using request.url_for(). This significantly improves the maintainability of the codebase. The changes are well-executed across auth.py and manager.py. I've added a few suggestions to further reduce code repetition by reusing RedirectResponse objects, which aligns with the goal of this refactoring.

@IngmarStein IngmarStein merged commit 90546c8 into tronbyt:main Nov 19, 2025
2 checks passed
@IngmarStein IngmarStein deleted the url_for branch November 19, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant