-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Enable shadowJar for jitpack dependency #1948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1948 +/- ##
============================================
- Coverage 43.47% 43.3% -0.17%
+ Complexity 4040 4023 -17
============================================
Files 510 510
Lines 29595 29595
Branches 3064 3064
============================================
- Hits 12865 12815 -50
- Misses 15564 15626 +62
+ Partials 1166 1154 -12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not necessary to build a "java-tron" jar.
What u need is FullNode.jar or SolidityNode.jar
| baseName = 'java-tron' | ||
| classifier = null | ||
| version = null | ||
| version = '1.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setting shadowJar.enabled = true can generate java-tron.jar. Not need a special version number.
DorianRust
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setting shadowJar.enabled = true can generate java-tron.jar. Not need a special version number.
What I needed was to include java-tron as a lib, I don't care about the the distrib jar (=same lib, different bundle) |
Ok thanks, I'm not sure this was working 6 months ago ... I close this request anyway. |
|
We already adopted your suggestion. |
What does this PR do?
Restore shadowJar build
Why are these changes required?
So that java-tron can be used as dependency with jitpack
This PR has been tested by:
Follow up
Extra details