Skip to content

Conversation

@nfleury
Copy link
Contributor

@nfleury nfleury commented Jan 18, 2019

What does this PR do?
Restore shadowJar build

Why are these changes required?
So that java-tron can be used as dependency with jitpack

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

codecov-io commented Jan 18, 2019

Codecov Report

Merging #1948 into develop will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #1948      +/-   ##
============================================
- Coverage      43.47%   43.3%   -0.17%     
+ Complexity      4040    4023      -17     
============================================
  Files            510     510              
  Lines          29595   29595              
  Branches        3064    3064              
============================================
- Hits           12865   12815      -50     
- Misses         15564   15626      +62     
+ Partials        1166    1154      -12
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/tron/core/db/PeersStore.java 17.24% <0%> (-17.25%) 2% <0%> (-2%)
...va/org/tron/common/overlay/discover/node/Node.java 50.84% <0%> (-11.87%) 12% <0%> (-3%)
...n/overlay/discover/node/statistics/Reputation.java 30.23% <0%> (-10.47%) 1% <0%> (-1%)
...tron/common/overlay/discover/node/NodeManager.java 44.02% <0%> (-8.18%) 22% <0%> (-2%)
...tron/common/overlay/discover/node/NodeHandler.java 46.34% <0%> (-6.51%) 17% <0%> (-3%)
...erlay/discover/node/statistics/NodeStatistics.java 38.55% <0%> (-4.82%) 4% <0%> (-3%)
...overlay/discover/node/statistics/MessageCount.java 52.77% <0%> (-2.78%) 6% <0%> (-1%)
.../java/org/tron/common/overlay/server/SyncPool.java 33.07% <0%> (-0.77%) 12% <0%> (-1%)
src/main/java/org/tron/core/db/Manager.java 43.07% <0%> (-0.21%) 116% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf0b575...3a79e3a. Read the comment docs.

Copy link
Contributor

@BlueHoopor BlueHoopor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not necessary to build a "java-tron" jar.
What u need is FullNode.jar or SolidityNode.jar

baseName = 'java-tron'
classifier = null
version = null
version = '1.0.0'
Copy link
Contributor

@DorianRust DorianRust Jun 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting shadowJar.enabled = true can generate java-tron.jar. Not need a special version number.

Copy link
Contributor

@DorianRust DorianRust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting shadowJar.enabled = true can generate java-tron.jar. Not need a special version number.

@nfleury
Copy link
Contributor Author

nfleury commented Jun 23, 2019

it's not necessary to build a "java-tron" jar.
What u need is FullNode.jar or SolidityNode.jar

What I needed was to include java-tron as a lib, I don't care about the the distrib jar (=same lib, different bundle)

@nfleury
Copy link
Contributor Author

nfleury commented Jun 23, 2019

setting shadowJar.enabled = true can generate java-tron.jar. Not need a special version number.

Ok thanks, I'm not sure this was working 6 months ago ... I close this request anyway.

@nfleury nfleury closed this Jun 23, 2019
@DorianRust
Copy link
Contributor

We already adopted your suggestion.

@jiangyy0824 jiangyy0824 mentioned this pull request Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants