Skip to content

Conversation

@xxo1shine
Copy link
Contributor

What does this PR do?
Synchronized broadcasting block, increase block broadcasting speed

Why are these changes required?
Reducing block loss rate, increasing network stability

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

Codecov Report

Merging #2144 into develop will increase coverage by 0.09%.
The diff coverage is 25%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2144      +/-   ##
=============================================
+ Coverage       41.9%   41.99%   +0.09%     
- Complexity      4322     4334      +12     
=============================================
  Files            544      544              
  Lines          32968    32973       +5     
  Branches        3591     3594       +3     
=============================================
+ Hits           13814    13847      +33     
+ Misses         17836    17801      -35     
- Partials        1318     1325       +7
Impacted Files Coverage Δ Complexity Δ
...n/core/net/messagehandler/InventoryMsgHandler.java 36.66% <ø> (+0.3%) 5 <0> (ø) ⬇️
...g/tron/common/overlay/discover/DiscoverServer.java 82.75% <0%> (+3.09%) 8 <0> (+1) ⬆️
...ain/java/org/tron/core/net/service/AdvService.java 19.16% <27.77%> (-10.59%) 10 <2> (-4)
...n/java/org/tron/core/net/message/BlockMessage.java 41.17% <0%> (-5.89%) 3% <0%> (-1%)
src/main/java/org/tron/core/db/Manager.java 42.55% <0%> (+0.17%) 122% <0%> (+1%) ⬆️
.../java/org/tron/common/overlay/server/SyncPool.java 33.84% <0%> (+0.76%) 13% <0%> (+1%) ⬆️
...overlay/discover/node/statistics/MessageCount.java 55.55% <0%> (+2.77%) 7% <0%> (+1%) ⬆️
...erlay/discover/node/statistics/NodeStatistics.java 43.37% <0%> (+4.81%) 7% <0%> (+3%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8070251...060a625. Read the comment docs.

Copy link
Contributor

@jiangyy0824 jiangyy0824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@xxo1shine xxo1shine merged commit 99b8a6d into develop May 5, 2019
@shydesky shydesky deleted the fast_forward_for_block branch November 13, 2019 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants