Skip to content

Conversation

@tjchern
Copy link
Contributor

@tjchern tjchern commented May 29, 2019

… B's function, null pointer.

What does this PR do?
fix the bug: contract A create contract B, after A suicide, when call B's function, null pointer.
Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@codecov-io
Copy link

codecov-io commented May 29, 2019

Codecov Report

Merging #2262 into release_3.6 will decrease coverage by 0.03%.
The diff coverage is 28.57%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release_3.6    #2262      +/-   ##
=================================================
- Coverage          42.57%   42.54%   -0.04%     
+ Complexity          4458     4342     -116     
=================================================
  Files                541      537       -4     
  Lines              33017    32492     -525     
  Branches            3653     3564      -89     
=================================================
- Hits               14057    13823     -234     
+ Misses             17612    17352     -260     
+ Partials            1348     1317      -31
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/tron/core/capsule/ReceiptCapsule.java 71.42% <25%> (-2.55%) 23 <0> (+1)
...main/java/org/tron/common/runtime/RuntimeImpl.java 60.88% <33.33%> (-0.22%) 51 <2> (+1)
src/main/java/org/tron/core/db/Manager.java 44.06% <0%> (-3.43%) 116% <0%> (-106%)
...ava/org/tron/core/db/accountstate/TrieService.java
.../accountstate/storetrie/AccountStateStoreTrie.java
...db/accountstate/callback/AccountStateCallBack.java
.../tron/core/db/accountstate/AccountStateEntity.java
.../java/org/tron/common/overlay/server/SyncPool.java 33.84% <0%> (+0.76%) 13% <0%> (+1%) ⬆️
src/main/java/org/tron/common/utils/ByteArray.java 56.66% <0%> (+3.33%) 16% <0%> (+1%) ⬆️
...g/tron/common/overlay/discover/DiscoverServer.java 82.75% <0%> (+8.62%) 8% <0%> (+2%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73d7536...257bd7c. Read the comment docs.

@CodeNinjaEvan CodeNinjaEvan merged commit 541a033 into release_3.6 May 29, 2019
@shydesky shydesky deleted the hotfix/fix_creator_is_null branch November 13, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants