Fix client consensus to use localhost address for cluster #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you very much for your proposal, it is a good way, I will adopt your plan.Hope we can communicate more later. |
zhaohong
pushed a commit
that referenced
this pull request
Feb 5, 2018
jHO1RqTmDtdFUmpqccbPiXlmYAZqm3fH87LiqDjLLkHO1bMMqtGy9sF5iL8uwgYt FBdPzQhMUx2Inj+480blRNEd3XVGR+oxuy1EXCi6bgXNAnnqXhRAVxCGKPE0nvVG P4A2/JBKYCn855aITSc69X4trTOxzi/Lcc0L65LOuVjWlF+XDzi51V6DPDVwhhoT Wm4yQc2G+2GWy6+y+8NSyI46V/CdV3hyN1Rgaene49LsZnU4zq7SWDMElGp6mKvC DRcF5d2hTdn5HAbqoucdYAMmheATWowSJ9qmRZCMP83TGOEKW4Gc3lYIS+TCUmY= =sKgA -----END PGP SIGNATURE----- Merge pull request #29 from Eyesonly88/develop Fix client consensus to use localhost address for cluster
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It makes the
getmessageandputmessagecommands work. The consensus server was hardcoded to "192.168.0.108" and I changed it to the server address.Why are these changes required?
Without doing this, the message commands just say
Connecting to "192.168.0.108". I tried this by following the guide using IntelliJ Idea.This PR has been tested by:
Tested by manually starting a consensus server then setting a message and getting it as you can see below
Follow up
I'm a beginner to blockchain development so please let me know if I'm doing something wrong or there is a better way of doing it.
I'm also not sure this is the best solution either but it seems to work :)