Skip to content

Conversation

@Sunny6889
Copy link

@Sunny6889 Sunny6889 commented Sep 16, 2025

What does this PR do?

  1. add implementation for SolidityNode in SolidityNodeHttpApiService.java
  2. skip Maintenance check for solidity request either in SolidityNode or FullNode

Why are these changes required?

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@Sunny6889 Sunny6889 changed the title fix: get now witness count fix(API): get now witness count Sep 16, 2025
@kuny0707 kuny0707 moved this to In Review in java-tron Sep 16, 2025
@kuny0707 kuny0707 linked an issue Sep 16, 2025 that may be closed by this pull request
@halibobo1205
Copy link
Contributor

Based on java-error-message-exposure considerations, I recommend that newly added APIs should no longer return detailed stack traces in their error responses.

image

@Sunny6889
Copy link
Author

Based on java-error-message-exposure considerations, I recommend that newly added APIs should no longer return detailed stack traces in their error responses.

image

Good suggestion, since all existing Servlet classes use this way, I suggest we do it next release with well-considered solutions.

@kuny0707 kuny0707 merged commit 732e7bc into tronprotocol:release_v4.8.1 Sep 17, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in java-tron Sep 17, 2025
halibobo1205 pushed a commit to halibobo1205/java-tron that referenced this pull request Oct 14, 2025
* add GetPaginatedNowWitnessList into SolidityNodeHttpApiService

* add isSolidityRequest check for MaintenanceUnavailableException

* add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add a new API to query the real-time vote count of witness

7 participants