github/workflows: Use split workflow instead of matrix #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I merged #22 but looks like it's not picked up by this PR. |
Contributor
|
Ah yes my patch was incomplete. Fixing soon. |
trusted-execution-clusters#22 set an MSRV for the workspace, but this doesn't have any effect before setting them for the crates. Set them there. Unblocks trusted-execution-clusters#29. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
| env: | ||
| CARGO_TERM_COLOR: always | ||
| # Pinned toolchain for linting | ||
| ACTIONS_LINTS_TOOLCHAIN: 1.85.0 |
Contributor
There was a problem hiding this comment.
this would need to be
Suggested change
| ACTIONS_LINTS_TOOLCHAIN: 1.85.0 | |
| ACTIONS_LINTS_TOOLCHAIN: 1.88.0 |
or we relax the MSRV back down to 1.85, #14 removed the constructs that required 1.88
Member
Author
There was a problem hiding this comment.
Let's start with 1.85.0 as that's what we use in CoreOS as that's what's in some version of RHEL. We can bump it back later.
Jakob-Naucke
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This split things a bit more and is what we use in other Rust based projects. Let's see if this is useful.
Not sure if that exactly covers what we have already.