fedora: Rename directories from fcos to fedora #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can assume throughout these repositories that the target OSes are
actually going to be for bootable containers. That is, that the
VARIANT_ID is "coreos".
To make things simpler, this commit sets the path to "fedora" instead of
"fcos" so it matches the way the other directories (rhel/centos) look
like. This way, the path can be elucidated based on the ${ID} from
/etc/os-release without any further processing.
Signed-off-by: Beñat Gartzia Arruabarrena <bgartzia@redhat.com>
This was referenced Sep 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can assume throughout these repositories that the target OSes are actually going to be for bootable containers. That is, that the VARIANT_ID is "coreos".
To make things simpler, this commit sets the path to "fedora" instead of "fcos" so it matches the way the other directories (rhel/centos) look like. This way, the path can be elucidated based on the ${ID} from /etc/os-release without any further processing.
At first sight I thought there were not going to be many dependencies to be updated apart from https://github.com/confidential-clusters/compute-pcrs/blob/main/justfile.
However, it seems like trusted-execution-clusters/operator#12 and trusted-execution-clusters/operator#14 refer to fcos paths too. I'm double checking there before moving on.