Skip to content

fix: fallback to global mvn if mvnw not found #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

fix: fallback to global mvn if mvnw not found #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 11 additions & 16 deletions src/providers/java_maven.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,24 +214,19 @@ export default class Java_maven extends Base_java {
try {
this._invokeCommand(mvnw, ['--version'])
} catch (error) {
if (error.code === 'ENOENT') {
useMvnw = false
} else {
throw new Error(`failed to check for mvnw`, {cause: error})
}
throw new Error(`failed to check for mvnw`, {cause: error})
}
mvn = useMvnw ? mvnw : mvn
return mvnw
}
} else {
// verify maven is accessible
try {
this._invokeCommand(mvn, ['--version'])
} catch (error) {
if (error.code === 'ENOENT') {
throw new Error(`maven not accessible at "${mvn}"`)
} else {
throw new Error(`failed to check for maven`, {cause: error})
}
}
// verify maven is accessible, if mvnw was not requested or not found
try {
this._invokeCommand(mvn, ['--version'])
} catch (error) {
if (error.code === 'ENOENT') {
throw new Error((useMvnw ? 'mvnw not found and ' : '') + `maven not accessible at "${mvn}"`)
} else {
throw new Error(`failed to check for maven`, {cause: error})
}
}
return mvn
Expand Down
Loading