don't impose request as first args

[RemiDesgrange]

I can see here : https://github.com/trustpilot/python-sanicargs/blob/master/sanicargs/__init__.py#L60 that naming the first args request is mandatory.

What do you think about checking that the first args is an instance of sanic.request ?

[sloev]

@RemiDesgrange
I've had time to look at the issue and i disagree that it is better to be flexible here.
Sanic framework is imposing the same behaviour on the path params:
request is first param, after that comes path params (see https://github.com/channelcat/sanic/blob/master/docs/sanic/routing.md#request-parameters)
So i think the query params should do the same.

What is your thoughts Remi?

[RemiDesgrange]

My proposal was to keep sanic.request instance as the first argument, but the name, should be changeable like:

from sanic import request
from sanic.response import json as resjson

@app.route('/<id:int>')
async def index(req: request, id: int) -> resjson:
    return resjson({'id': id, 'headers': req.json}

[sloev]

@RemiDesgrange
like in this PR:
#3
check the diff files to see how its used in the tests

[sloev]

fixed in #3

[RemiDesgrange]

Thanks !!! didn't see your notification, sorry

[sloev]

@RemiDesgrange hope it suits your usecase. Please report if you find anything else.

• jgv

[RemiDesgrange]

👌👌👌 Le jeu. 1 mars 2018 à 20:34, Johannes Gårdsted Valbjørn < notifications@github.com> a écrit :

…

@RemiDesgrange <https://github.com/remidesgrange> hope it suits your usecase. Please report if you find anything else. - jgv — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMqC1XhnmKgSAphdsYhDlHDq8aKLSJfbks5taE1fgaJpZM4SEFkI> .