-
Notifications
You must be signed in to change notification settings - Fork 227
[dev] [tofikwest] tofik/portal-sign-in-email-otp-error #1870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR SummaryPass request headers to email OTP sign-in, adapt Better Auth config, and upgrade better-auth to 1.4.5.
Written by Cursor Bugbot for commit 390989d. This will update automatically on new commits. Configure here. |
Graphite Automations"Auto-assign PRs to Author" took an action on this PR • (12/05/25)1 reviewer was added to this PR based on Mariano Fuentes's automation. |
| email: parsedInput.email, | ||
| otp: parsedInput.otp, | ||
| }, | ||
| asResponse: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Missing response status check causes false login success
When using asResponse: true with auth.api.signInEmailOTP, the API returns a Response object instead of throwing on errors. The code ignores this response and unconditionally returns { success: true }, meaning failed OTP authentication (invalid/expired codes) will incorrectly report success to the client. Other usages of asResponse: true in the codebase properly check response.ok before considering the operation successful.
|
🎉 This PR is included in version 1.68.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is an automated pull request to merge tofik/portal-sign-in-email-otp-error into dev.
It was created by the [Auto Pull Request] action.