-
Notifications
You must be signed in to change notification settings - Fork 227
feat(api): add access request notification email functionality #1910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR SummarySends an email notification to organization contacts/admins when a new Trust Portal access request is submitted, using a new email template and email service method.
Written by Cursor Bugbot for commit efa0bcc. This will update automatically on new commits. Configure here. |
Graphite Automations"Auto-assign PRs to Author" took an action on this PR • (12/12/25)1 assignee was added to this PR based on Mariano Fuentes's automation. |
|
🎉 This PR is included in version 1.70.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
| } | ||
|
|
||
| // Construct review URL | ||
| const reviewUrl = `${process.env.BETTER_AUTH_URL}/${organizationId}/trust`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Unused requestId parameter prevents deep-linking to request
The requestId parameter is passed to sendAccessRequestNotificationToOrg but is never used in the function body. The reviewUrl on line 218 only includes the organization trust page (/${organizationId}/trust) without the specific request ID. This likely represents an incomplete implementation where the URL was meant to deep-link to the specific access request (e.g., /${organizationId}/trust/requests/${requestId}) so admins can review it directly, rather than landing on the general trust page and having to find the request themselves.
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist