Skip to content

Conversation

@Marfuen
Copy link
Contributor

@Marfuen Marfuen commented Jan 2, 2026

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes COMP-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel
Copy link

vercel bot commented Jan 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
app Ready Ready Preview, Comment Jan 2, 2026 8:37pm
portal Ready Ready Preview, Comment Jan 2, 2026 8:37pm

@cursor
Copy link

cursor bot commented Jan 2, 2026

PR Summary

Improves robustness of NDA PDF processing by gracefully handling encrypted inputs.

  • Import EncryptedPDFError from pdf-lib
  • In watermarkExistingPdf, wrap PDFDocument.load in try/catch; on EncryptedPDFError, log and return original pdfBuffer without watermark; rethrow other errors
  • No changes to generateNdaPdf or watermark rendering logic

Written by Cursor Bugbot for commit 304e1de. This will update automatically on new commits. Configure here.

@graphite-app
Copy link

graphite-app bot commented Jan 2, 2026

Graphite Automations

"Auto-assign PRs to Author" took an action on this PR • (01/02/26)

1 assignee was added to this PR based on Mariano Fuentes's automation.

@Marfuen Marfuen merged commit 2808706 into main Jan 2, 2026
6 of 8 checks passed
@Marfuen Marfuen deleted the mariano/vercel-perms branch January 2, 2026 20:35
claudfuen pushed a commit that referenced this pull request Jan 2, 2026
## [1.72.1](v1.72.0...v1.72.1) (2026-01-02)

### Bug Fixes

* **api:** enhance error handling for encrypted PDFs in NDA processing ([#1966](#1966)) ([d786d79](d786d79))
* **api:** handle encrypted PDFs in NDA PDF processing ([#1965](#1965)) ([2808706](2808706))
* **api:** improve text cleaning for PDF rendering by stripping invisible unicode characters ([#1962](#1962)) ([67a37d5](67a37d5))
@claudfuen
Copy link
Contributor

🎉 This PR is included in version 1.72.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants